[P4Testgen] BMv2 test generation improvements #4046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen constraints are not feasible.
… either a wildcard or an exact match.
fruffy
force-pushed
the
fruffy/benchmarking_fixes
branch
from
f590c26
to
0d1ad79
Compare
fruffy
force-pushed
the
fruffy/benchmarking_fixes
branch
from
93b379c
to
3d158dc
Compare
jafingerhut
reviewed
Jun 27, 2023
| @@ -404,10 +404,10 @@ class Test{{test_id}}(AbstractTest): | |||
| ## else | |||
| ptfutils.verify_packet(self, exp_pkt, eg_port) | |||
| bt.testutils.log.info("Verifying no other packets ...") | |||
| ptfutils.verify_no_other_packets(self, self.device_id, timeout=2) | |||
| ptfutils.verify_no_other_packets(self, self.device_id, timeout=0.1) | |||
There was a problem hiding this comment.
I would recommend maybe using a global variable name or a return value from a global function defined with def at the top level to get this timeout value, so that after a PTF test is generated, a user can replace this number in one place in the PTF source file, rather than many places.
Similarly if there are other timeouts to wait for a different reason.
There was a problem hiding this comment.
Rationale: 0.1 sec might work right now for BMv2, but I've been testing with other environments where it is definitely not long enough.
There was a problem hiding this comment.
What are the environments where issues are coming up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entry_restrictionparser and print a warning if a restriction is not satisfiable. Also ensure argument and parameter names are consistent.